New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revision selection during (beta) repository installation #4944

Merged
merged 7 commits into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@mvdbeek
Member

mvdbeek commented Nov 6, 2017

Without this the model would be refetched and would remain at the initial changeset revision.

Other fixes:

  • the revision dropdown is ordered by revision.
  • installation of missing tools for workflows.
  • A KeyError for metadata dicts that don't include tool dependencies
Fix revision selection during installation
Without this the model would be refetched and would remain at the initial
changeset revision.

@mvdbeek mvdbeek changed the title from [WIP] Fix revision selection during (beta) repository installation to Fix revision selection during (beta) repository installation Nov 6, 2017

@mvdbeek mvdbeek added status/review and removed status/WIP labels Nov 6, 2017

@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Nov 6, 2017

If we can fix the tool panel selection I think we could make this the default for 18.01 ...

@galaxybot galaxybot added this to the 18.01 milestone Nov 6, 2017

mvdbeek and others added some commits Nov 11, 2017

Fix KeyError in beta repository installation
Repository metadata may not include tool dependencies.

@jmchilton jmchilton merged commit 3a9d63c into galaxyproject:dev Dec 7, 2017

0 of 6 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
selenium test Test started.
Details
toolshed test Test started.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Dec 7, 2017

Awesome - thanks a bunch!

@mvdbeek mvdbeek deleted the mvdbeek:beta_tool_install_fixes branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment