New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trackster styles bleeding into the app (the slightly offcenter upload .icon buttons) #4948

Merged
merged 3 commits into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Nov 6, 2017

Per discussion in #4946, this fixes #4929 by 1) removing the trackster css overrides, because that style isn't actually used by live trackster code anyway, and 2) more importantly, should wait to load trackster CSS until a trackster view is actually created, preventing automatic loading when that code is encounted in the bundles.

@dannon dannon changed the title from Fix trackster styles to Fix trackster styles bleeding into the app (the slightly offcenter upload .icon buttons) Nov 6, 2017

@dannon dannon requested a review from guerler Nov 6, 2017

@galaxybot galaxybot added the triage label Nov 6, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 6, 2017

@guerler

guerler approved these changes Nov 6, 2017

@guerler guerler merged commit 74b37a9 into galaxyproject:dev Nov 6, 2017

7 checks passed

api test Build finished. 309 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment