New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid user preferences beta (no longer a beta, always enabled) #4957

Merged
merged 6 commits into from Nov 8, 2017

Conversation

Projects
None yet
4 participants
@dannon
Member

dannon commented Nov 8, 2017

Fixes #4956, as well as cleaning up two other deprecated preferences and fixing several typos.

@dannon dannon added status/review and removed status/WIP labels Nov 8, 2017

@martenson

This comment has been minimized.

Member

martenson commented Nov 8, 2017

Lgtm. Maybe just for the peace of mind we should make sure to put this into release notes config changes. I do not think it warrants deprecation round though.

@martenson martenson referenced this pull request Nov 8, 2017

Closed

Publication of Galaxy Release v 18.01 #4920

49 of 52 tasks complete
@dannon

This comment has been minimized.

Member

dannon commented Nov 8, 2017

@martenson Yeah, the features corresponding to these entries are either already gone (sequencer communication) or integrated completely (toolform and preferences upgrades) and the entries in galaxy.ini are completely ignored.

# File where Data Managers are configured (.sample used if default does not
# exist).
#data_manager_config_file = config/data_manager_conf.xml
# File where Tool Shed based Data Managers are configured.
#shed_data_manager_config_file = config/shed_data_manager_conf.xml

This comment has been minimized.

@nsoranzo

nsoranzo Nov 8, 2017

Member

Add blank line here too?

This comment has been minimized.

@dannon

dannon Nov 8, 2017

Member

@nsoranzo Thanks, missed that one in my reformatting!

@nsoranzo nsoranzo added this to the 18.01 milestone Nov 8, 2017

@martenson martenson merged commit 963cfd1 into galaxyproject:dev Nov 8, 2017

4 of 7 checks passed

api test Build finished. No test results found.
Details
framework test Build finished. No test results found.
Details
selenium test Build finished. No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@guerler

This comment has been minimized.

Contributor

guerler commented Nov 8, 2017

Thanks @dannon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment