New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier upgrade #4964

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Nov 8, 2017

Fixes comment formatting (the wonky indentations) and understands string literal breaks a little better, splitting of lines > 120 chars on interpolation { stuff }.

This fixes #4865

@galaxybot galaxybot added this to the 18.01 milestone Nov 8, 2017

@martenson martenson merged commit 8ce7d29 into galaxyproject:dev Nov 9, 2017

7 checks passed

api test Build finished. 309 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Member

martenson commented Nov 9, 2017

thanks @dannon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment