New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up reports javascript #4967

Merged
merged 4 commits into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@dannon
Member

dannon commented Nov 9, 2017

The stats displays were failing and needed some TLC. Includes many small fixes, but primarily resolves the loading issues by using require and updating imports from globals to defined modules.

@dannon dannon changed the title from Fix up admin panel's javascript to Fix up reports javascript Nov 9, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 9, 2017

@martenson

This comment has been minimized.

Member

martenson commented Nov 9, 2017

Heh, I ran reports yesterday to check but did not open the page :) Good catch.

@martenson martenson merged commit 0a3b525 into galaxyproject:dev Nov 9, 2017

7 checks passed

api test Build finished. 309 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@guerler

This comment has been minimized.

Contributor

guerler commented Nov 9, 2017

Thanks for the quick fix @dannon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment