Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture labelled screenshots of Galaxy during PR CI testing. #4971

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Nov 9, 2017

During pull requests reviews this allows easy visual inspection of various components to augment the automated testing.

Capture a bunch of labelled screenshots of Galaxy durings tests.
During pull requests reviews this allows easy visual inspection of various components to augment the automated testing.
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2017

xref https://jenkins.galaxyproject.org/job/docker-selenium/71/artifact/71-test-screenshots/ - pulling out of WIP. Not all the screenshots are perfect yet (looks like Galaxy components are still loading in at least a few of them) but I think it is still useful to have what is there for future PR reviews. There are some hard to test screenshots like tool upgrade messages and such - I think this should be useful.

@jmchilton jmchilton changed the title [WIP] Capture labelled screenshots of Galaxy during PR CI testing. Capture labelled screenshots of Galaxy during PR CI testing. Nov 9, 2017

@jmchilton jmchilton added status/review and removed status/WIP labels Nov 9, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 9, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Nov 10, 2017

This seems very useful!

@martenson martenson merged commit 438177d into galaxyproject:dev Nov 10, 2017

7 checks passed

api test Build finished. 310 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.