Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run `hg clone` in a subprocess instead of using Mercurial API #4979

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@nsoranzo
Copy link
Member

nsoranzo commented Nov 10, 2017

Using the API is discouraged by upstream, see:

https://www.mercurial-scm.org/wiki/MercurialApi

Moreover, the old code randomly causes the following error when installing big ToolShed repositories (e.g. any qiime tool) through the admin UI:

tool_shed.util.hg_util DEBUG 2017-11-03 17:36:45,950 Error cloning repository: signal only works in main thread

This error occurs when Galaxy runs under Paste and also when it runs under uWSGI with multiple threads per process.

Run `hg clone` in a subprocess instead of using Mercurial API
Using the API is discouraged by upstream, see:

https://www.mercurial-scm.org/wiki/MercurialApi

Moreover, the old code randomly causes the following error when installing
big ToolShed repositories (e.g. any qiime tool) through the admin UI:

tool_shed.util.hg_util DEBUG 2017-11-03 17:36:45,950 Error cloning repository: signal only works in main thread

This error occurs when Galaxy runs under Paste and also when it runs under
uWSGI with multiple threads per process.
@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Nov 11, 2017

This is working well for me, thanks a lot @nsoranzo !

@jmchilton jmchilton merged commit 0799e51 into galaxyproject:dev Nov 13, 2017

7 checks passed

api test Build finished. 310 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:hg_clone branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.