New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05][BUG] Specify TagAssociation class when copying a tag #4984

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Member

mvdbeek commented Nov 11, 2017

This probably fixes #4975.
Otherwise if a collection is created from a HDA with a tag (i.e by splitting the dataset)
a HistoryDatasetAssociationTag would be added to a collection of
HistoryDatasetCollectionAssociationTags.

Specify TagAssociation class when copying a tag
This probably fixes #4975.
Otherwise if a collection is created from a HDA with a tag (i.e by splitting the dataset)
a HistoryDatasetAssociationTag would be added to a collection of
HistoryDatasetCollectionAssociationTags.
@dannon

This comment has been minimized.

Member

dannon commented Nov 13, 2017

+1, thanks @mvdbeek. Not super keen on the caller needing to know this argument to copy() long term, but this should fix the problem with collections now. Maybe down the road we try to unify this with some of the copy_tags_from methods, adding some logic to create the right objects by default?

@dannon dannon merged commit e5587dc into galaxyproject:release_17.05 Nov 13, 2017

7 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Nov 13, 2017

That's a good idea, let's do that moving forward!

@mvdbeek mvdbeek deleted the mvdbeek:fix_crash_when_creating_collection_from_datasets_with_tags branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment