New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allow-register option in auth module #4989

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Member

nsoranzo commented Nov 13, 2017

config/auth_conf.xml.sample specifies that the possible values are True, False and Challenge.
Broken in commit b3174ef .

Also remove _get_bool(d, k, o) function in favour of the more explicit string_as_bool(d.get(k, o)) .

Fix allow-register option in auth module
config/auth_conf.xml.sample specifies that the possible values are
True, False and Challenge.
Broken in commit b3174ef .

Also remove _get_bool(d, k, o) function in favour of the more explicit
`string_as_bool(d.get(k, o))` .
@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 13, 2017

Sorry :(

@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Nov 13, 2017

I suppose no-one ever used this option, so don't worry!

@jmchilton jmchilton merged commit 9d9c323 into galaxyproject:dev Nov 13, 2017

5 of 7 checks passed

framework test Build finished. No test results found.
Details
selenium test Build finished. 98 tests run, 1 skipped, 2 failed.
Details
api test Build finished. 310 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:fix_allow-register branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment