New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox envlist to contain all envs that should pass #4992

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Member

nsoranzo commented Nov 13, 2017

Now simply running:

$ tox

is the equivalent of running all the Travis jobs that are not in the allow_failures list.

Also:

  • remove py33-lint env
  • sort envs alphabetically
Fix tox envlist to contain all envs that should pass
Now simply running:
```
$ tox
```
is the equivalent of running all the Travis jobs that are not in the
`allow_failures` list.

Also:
- remove py33-lint env
- sort envs alphabetically

@nsoranzo nsoranzo added this to the 18.01 milestone Nov 13, 2017

@nsoranzo nsoranzo requested a review from jmchilton Nov 13, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 13, 2017

Very nice - I just sort of thought that was a list of all the environments (but obviously this is wrong since you can combine identifiers in various ways so I didn't really think that through). Thanks a bunch!

whitelist_externals = bash
skip_install = True

This comment has been minimized.

@nsoranzo

nsoranzo Nov 13, 2017

Member

@jmchilton Should we add skip_install = True to all lint envs?

This comment has been minimized.

@jmchilton

jmchilton Nov 13, 2017

Member

Yes I think so - I'll follow this PR up with one that does that and takes care of the dev dependencies - they shouldn't be defined in this file - they should go in the global dev dependencies for Galaxy.

@jmchilton jmchilton merged commit 148e91f into galaxyproject:dev Nov 13, 2017

7 checks passed

api test Build finished. 310 tests run, 5 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:fix_tox_envlist branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment