New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise workflow create form, remove unused rename endpoint #4996

Merged
merged 18 commits into from Nov 24, 2017

Conversation

Projects
None yet
3 participants
@guerler
Contributor

guerler commented Nov 13, 2017

Follow-up for #4047. ping @anuprulez.

guerler added some commits Nov 13, 2017

return {
'title' : 'Create Workflow',
'inputs' : [{
'name' : 'workflow_name',

This comment has been minimized.

@anuprulez

anuprulez Nov 14, 2017

Member

thanks @guerler

I want to share one use case not specifically to this pull request but in general related to workflows.
When a user creates a workflow, "Unnamed workflow" appears as the default workflow name. Let's say it is saved. If she/ he creates another workflow, the default workflow name appears as "Unnamed workflow" again (even though there is already a workflow present with this name) and the application allows to have the same workflow name. Thanks!

unnamed_workflow

guerler and others added some commits Nov 13, 2017

Fix selector
Fix

Fix

@guerler guerler added status/review and removed status/WIP labels Nov 21, 2017

@guerler

This comment has been minimized.

Contributor

guerler commented Nov 21, 2017

Thx for your help @jmchilton

@jmchilton jmchilton merged commit e03ea6d into galaxyproject:dev Nov 24, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment