New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance hdca creation API endpoint to accept lddas #4998

Merged
merged 7 commits into from Nov 15, 2017

Conversation

2 participants
@martenson
Member

martenson commented Nov 13, 2017

by implementing automatic conversion of any such elements

enhance hdca creation endpoint to accept lddas
by implementing automatic conversion of any such elements

@martenson martenson added this to Done in Data Libraries Nov 14, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 15, 2017

Conflict solved with this PR martenson#25 - which also adds various new library tests including covering this new functionality.

Merge pull request #25 from jmchilton/lib-to-colllection
Merge with dev and add more tests.
@martenson

This comment has been minimized.

Member

martenson commented Nov 15, 2017

@jmchilton merged, thanks a lot!

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 15, 2017

I gave you a failing test - I'm sorry. I'll open another PR with a fix and some more refactoring I'd like to see this afternoon if that is okay.

@jmchilton jmchilton merged commit 38c620c into galaxyproject:dev Nov 15, 2017

0 of 6 checks passed

api test Test started.
Details
framework test Test started.
Details
integration test Test started.
Details
lgtm analysis: JavaScript Fetching Git Commits
Details
selenium test Test started.
Details
toolshed test Test started.
Details

@martenson martenson moved this from Done to Closed in Data Libraries Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment