Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Add missing ipaddress requirement #5000

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Nov 14, 2017

Broken in #4289 .

Fix #4999 .

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2017

It was never an issue because it gets installed anyway, at least for me:

Collecting ipaddress; python_version < "3" (from cryptography>=1.1->paramiko==2.2.1->-r requirements.txt (line 74))

But explicit is better than implicit.

@dannon dannon merged commit 18467e9 into galaxyproject:release_17.09 Nov 15, 2017

7 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:release_17.09_add_ipaddress_requirement branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.