Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import order everywhere #5005

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
4 participants
@nsoranzo
Copy link
Member

commented Nov 14, 2017

  • Add flake8-import-order to flake8 Pipfile and remove py27-lint-imports and py27-lint-imports-include-list tox envs
  • Fix most E201 and E202 errors reported by flake8-import-order v0.15, but pin flake8-import-order to v0.14.3 until PyCQA/flake8-import-order#123 is fixed

This let us drop 2 jobs on Travis per each job.

Fix import order everywhere
- Add flake8-import-order to flake8 Pipfile and remove py27-lint-imports
  and py27-lint-imports-include-list tox envs
- Fix most E201 and E202 errors reported by flake8-import-order v0.15,
  but pin flake8-import-order to v0.14.3 until
  PyCQA/flake8-import-order#123
  is fixed

This let us drop 2 jobs on Travis per each job.

@nsoranzo nsoranzo force-pushed the nsoranzo:flake8-import-order branch from 07168b2 to 2cd95c4 Nov 14, 2017


from galaxy.web import _future_expose_api_anonymous_and_sessionless as expose_api_anonymous_and_sessionless
from galaxy.web import _future_expose_api as expose_api
from galaxy.web import _future_expose_api as expose_api_anonymous

This comment has been minimized.

Copy link
@jmchilton

jmchilton Nov 14, 2017

Member

You caught a bug here but didn't note it - clearly this shouldn't cause any regressions but I guess I'll ping @erasche in case he wants to try to make this anonymously exposed again.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Nov 14, 2017

Author Member

Yep, I tried to change this to:

from galaxy.web import _future_expose_api_anonymous as expose_api_anonymous

but doing a GET /api/whoami while not logged in results in an error because current_user is None.

This comment has been minimized.

Copy link
@erasche

erasche Nov 14, 2017

Member

No, need to expose it anonymously. Thanks for the ping @jmchilton

@dannon dannon merged commit 7c1afa8 into galaxyproject:dev Nov 14, 2017

7 checks passed

api test Build finished. 310 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented Nov 14, 2017

Nice, thanks!

@nsoranzo nsoranzo deleted the nsoranzo:flake8-import-order branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.