Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.07] history contents api - remove the default flag override #5008

Merged

Conversation

Projects
None yet
2 participants
@martenson
Copy link
Member

martenson commented Nov 14, 2017

Since it is wrong and causes ignoring the access permissions.

remove the default override
since it is wrong and ignores the access permissions

@martenson martenson added this to the 18.01 milestone Nov 14, 2017

@martenson martenson changed the title history contents api - remove the default flag override [16.07] history contents api - remove the default flag override Nov 14, 2017

@jmchilton jmchilton merged commit 9a13a4a into galaxyproject:release_16.07 Nov 15, 2017

6 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 112 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Nov 15, 2017

Thanks @martenson - merged into every subsequent release and into dev.

@martenson martenson deleted the martenson:fix-ldda-access-check branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.