Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[17.09] Do not visit child inputs of invalid conditionals #5010
Fixes #4889. Invalid conditionals states are usually the result of tool version changes. Child inputs of invalid conditionals should not be visited if the underlying visitor is unable to fix them. The only input visitor which is able to resolve them and warn the user is
Yeah, I created a local test tool with a conditional parameter which has a data parameter as child input (see https://gist.github.com/guerler/1979ad03916b42aaf3fc4e2a0d608e81). Remove the conditional parameter and add the tool to a workflow. Save it, and add it to a page. Then re-add the conditional parameter to the tool xml, reload the instance and load the page. This reproduces the issue. I added a couple test cases to this PR to capture this behavior.