New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_interpreter: log a warning only if interpreter is set #5015

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Member

nsoranzo commented Nov 15, 2017

Also return None instead of False if there is no <command>.
Fix typo in warning.

parse_interpreter: log a warning only if interpreter is set
Also return None instead of False if there is no `<command>`.
Fix typo in warning.

@nsoranzo nsoranzo added this to the 18.01 milestone Nov 15, 2017

@jmchilton jmchilton merged commit 5c28618 into galaxyproject:dev Nov 15, 2017

7 checks passed

api test Build finished. 310 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:fix_parse_interpreter branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment