New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add API that allows admins to decode galaxy objects' ids #5018

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@martenson
Member

martenson commented Nov 15, 2017

ping @erasche I think you requested this in the past too?

assert decoded_library_id == folder_response_id
def test_normal_user_decode_id(self):
decode_response = self._get("configuration/decode/badhombre", admin=False)

This comment has been minimized.

@erasche

erasche Nov 15, 2017

Member

(I trust the @require_admin flag, but) shouldn't we test decoding a valid ID with admin=False?

This comment has been minimized.

@martenson

martenson Nov 16, 2017

Member

this technically tests that, since the response won't be 403

@erasche

This comment has been minimized.

Member

erasche commented Nov 15, 2017

sounds like something I'd request :) LGTM 👍

@jmchilton jmchilton merged commit db2c3a4 into galaxyproject:dev Nov 20, 2017

7 checks passed

api test Build finished. 315 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 20, 2017

Thanks Martin - I really just wanted to have a plan for how to do this but an actual implementation is great. Thanks for putting this together!

@martenson martenson deleted the martenson:api-for-admin-decode branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment