New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow editor outputs fixes #5021

Merged
merged 3 commits into from Nov 18, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Nov 16, 2017

Separates nested function declarations which were inheriting misleading vars from parent scope. Options and required context are now passed in as params.

(also, some minor cleanup and js standardization)

This fixes #5019. Looking up when it was broken, and will backport a more minimal version.

Culprit is 338abee, which is in 17.09, so I'll work on that minimal backport.

dannon added some commits Nov 15, 2017

Fix workflow editor output attributes (var shadowing was silently mak…
…ing *everything* the first output attribute...)

@dannon dannon added status/review and removed status/WIP labels Nov 16, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 16, 2017

@guerler guerler merged commit 299ae5c into galaxyproject:dev Nov 18, 2017

7 checks passed

api test Build finished. 313 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek referenced this pull request Dec 1, 2017

Merged

Merge forward 17 09 #5108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment