New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix workflow editor output attributes. #5022

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
5 participants
@dannon
Member

dannon commented Nov 16, 2017

This correctly shadows the output_id var in the workflow forms initial setup, resolving the problem discussed in #5019 and #5021 , and is a cleaner fix for the backport. We should still merge #5021 (in dev), though, as it contains refactoring to prevent this sort of mistake down the road and cleans up a few more things. (this was a pain to track down)

@lparsons Let me know if this works for you.

@guerler

This comment has been minimized.

Contributor

guerler commented Nov 16, 2017

👍 Thx for the fix @dannon.

@martenson martenson merged commit 2a0c711 into galaxyproject:release_17.09 Nov 16, 2017

7 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

galaxybot commented Nov 16, 2017

This PR was merged without a milestone attached.

@martenson martenson added this to the 18.01 milestone Nov 16, 2017

@martenson

This comment has been minimized.

Member

martenson commented Nov 16, 2017

mind your business, bot!

@mvdbeek mvdbeek referenced this pull request Dec 1, 2017

Merged

Merge forward 17 09 #5108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment