New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsummary python3 fix #5043

Merged
merged 10 commits into from Nov 20, 2017

Conversation

Projects
None yet
7 participants
@bernt-matthias
Contributor

bernt-matthias commented Nov 20, 2017

the conda requirement implies python3 for this tool.

affects also 17.09

xref. #1715

@erasche

This comment has been minimized.

Member

erasche commented Nov 20, 2017

Locally we have the following change, in addition to removing the b

diff --git a/tools/stats/gsummary.xml b/tools/stats/gsummary.xml
index 86c7407..b35ec58 100644
--- a/tools/stats/gsummary.xml
+++ b/tools/stats/gsummary.xml
@@ -4,6 +4,7 @@
     <edam_topic>topic_2269</edam_topic>
   </edam_topics>
   <requirements>
+    <requirement type="package" version="2.7">python</requirement>
     <requirement type="package" version="2.7.8">rpy2</requirement>
   </requirements>
   <stdio>
@bernt-matthias

This comment has been minimized.

Contributor

bernt-matthias commented Nov 20, 2017

@erasche I could add this or increase rpy2 to the latest version (which does not work with python2). Any preferences? I guess it does not matter for the basic statistics done here.

@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Nov 20, 2017

@bernt-matthias rpy2 is available in conda-forge for Python 2.7, 3.5 and 3.6, see https://anaconda.org/conda-forge/rpy2/files . I don't think any python requirement should be needed.

@galaxybot galaxybot added the triage label Nov 20, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 20, 2017

@bernt-matthias

This comment has been minimized.

Contributor

bernt-matthias commented Nov 20, 2017

Sorry confused this with pip. Anyway, then I leave it as is and do not add the python requirement.

@bgruening bgruening added area/tools and removed triage labels Nov 20, 2017

@bgruening bgruening merged commit b2cc634 into galaxyproject:dev Nov 20, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Member

bgruening commented Nov 20, 2017

Thanks!

dannon added a commit that referenced this pull request Mar 5, 2018

@martenson martenson added the kind/bug label Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment