New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SA objects between workflow invocation scheduling attempts. #5045

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Nov 20, 2017

This would seem to be a fairly serious memory leak in the abstract but I don't have data that it fixes anything. None the less if it gets into dev and the tests seem to pass I'll open a PR to backport it to at least 17.05 and maybe back even more.

xref #5044

Cleanup SA objects between workflow invocation scheduling attempts.
This would seem to be a fairly serious memory leak in the abstract but I don't have data that it fixes anything. None the less if it gets into dev and the tests seem to pass I'll open a PR to backport it to at least 17.05 and maybe back even more.
@martenson

This comment has been minimized.

Member

martenson commented Nov 21, 2017

nice catch

@martenson martenson merged commit e9ef110 into galaxyproject:dev Nov 21, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@erasche

This comment has been minimized.

Member

erasche commented Nov 21, 2017

👍 would love to have this backported!

@jmchilton jmchilton referenced this pull request Nov 24, 2017

Merged

[17.09] Backport #5045 #5073

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 24, 2017

@erasche Wanna give it a try #5073? If y'all use it and it doesn't break things in 17.09 I may back port it further - this would seem to be a serious issue potentially.

@erasche

This comment has been minimized.

Member

erasche commented Nov 27, 2017

Absolutely! We'll test it out.

erasche added a commit that referenced this pull request Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment