New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemap removal #5054

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
4 participants
@dannon
Member

dannon commented Nov 21, 2017

This trims the size of committed artifacts pretty significantly, and will allow developers to build maps for debugging locally. In the very near future we're going to stop committing /static/* as well, which will be built by a jenkins bot on merge.

(followup PR will configure local developer build modes more fully)

@galaxybot galaxybot added the triage label Nov 21, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 21, 2017

@dannon dannon added status/review and removed triage labels Nov 22, 2017

@guerler guerler merged commit 7ee9215 into galaxyproject:dev Nov 22, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Member

martenson commented Nov 22, 2017

@guerler There was an ongoing discussion about this at gitter - that sadly we did not mirror here - which we should probably finish.

the latest point from @jmchilton

I've articulated why I think having the references to source maps even though they are not checked in are valuable - that it will work differently in the future is not a reason to drop them, make it harder to get them working with Galaxy for now, or complicate things today IMO. I'm not rushing to get something random in - we all just agreed dropping them was a very high priority item.

@dannon

This comment has been minimized.

Member

dannon commented Nov 22, 2017

xref #5058.

@guerler

This comment has been minimized.

Contributor

guerler commented Nov 22, 2017

Im sorry, I did not want to interfere with the discussion. This PR looked decent to me and removed a lot of the maps. Sorry if I rushed it. If there are plans to reverse or revise it I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment