New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Karma configuration and options. #5066

Merged
merged 4 commits into from Nov 27, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Nov 24, 2017

Builds on #5063

  • Speed up qunit testing but not re-building production bundles that aren't used anyway.
  • Add a watch option for qunit (this is as close as I think we are going to get to closing the speed issues mentioned in #4843 I think.)
  • Add option to speed up running all tests by building tests as single bundle instead of many bundles (may be future default for make client-test.)
  • Generally more correct usage of karma-webpack and auto watch options I think.

jmchilton added some commits Nov 23, 2017

Improved qunit testing options.
- Speed up qunit testing but not re-building production bundles that aren't used anyway.
- Add a watch option for qunit.
- Add option to speed up running all tests by building tests as single bundle instead of many bundles. (May be future default for ``make client-test``.)

This is as close as I think we are going to get to closing #4843.

@galaxybot galaxybot added this to the 18.01 milestone Nov 24, 2017

@martenson martenson merged commit d82933d into galaxyproject:dev Nov 27, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Member

martenson commented Nov 27, 2017

Thanks John, looks much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment