New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium test for tool citations. #5068

Merged
merged 6 commits into from Nov 30, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Nov 24, 2017

No description provided.

@jmchilton jmchilton added status/review and removed status/WIP labels Nov 28, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 28, 2017

Pulling this out of WIP I guess - the tests are producing slight different screenshots/citation counts for me locally than on Jenkins but switched the assertions around so this shouldn't cause build failures. Better we are testing the bits we are and get the screenshots we get than that we test nothing.

@dannon

This comment has been minimized.

Member

dannon commented Nov 30, 2017

Looks good to me.

@dannon dannon merged commit d8fe56c into galaxyproject:dev Nov 30, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 101 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment