New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More QUnit Fixes and Enhancements #5074

merged 9 commits into from Nov 30, 2017


None yet
2 participants

jmchilton commented Nov 25, 2017

Builds on the Karma configuration improvements in #5066.

  • Rename all test files for consistency.
  • Fix random things in tests that were commented out.
  • Enable a default karma configuration that works for all the tests (switching Karma to build a single bundle instead of a bundle per test fixed a lot of interaction problems between the tests).
  • Convert all the tests to ES6, run prettier.
  • Comment out on last failing test that we don't really need anyway - better covered by existing Selenium functional tests.

jmchilton added some commits Nov 25, 2017

Fixup modal_tests.js
Disable jQuery FX instead of mocking time - mocking time with sinon seems to not be working :(. Tests are conceptually cleaner this way IMO anyway.
Switch qunit testing to producing a single webpack bundle.
I think a lot of the remaining issues stem from attempting to load multiple bundles in the same web browser window - repeatedly loading jQuery, select2, etc.... This variant is much closer to running all the tests in a seemingly more flexible order and I've never seen a select2 problem this way.
Convert qunit tests to ES6.
... and make client-format them.

This comment has been minimized.


jmchilton commented Nov 27, 2017

Rebased with the merge of #5066 (thanks @martenson)!


This comment has been minimized.


dannon commented Nov 30, 2017

We'll definitely want to follow up on the side effects down the road, but it's not a reason to hold this up I don't think. As mentioned elsewhere, but for documentation here, the main side effect I was seeing cause failures was a redefinition of jQuery without select2 or other plugins attached.

@dannon dannon merged commit 1b4d8e5 into galaxyproject:dev Nov 30, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
continuous-integration/travis-ci/pr The Travis CI build passed
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
lgtm analysis: JavaScript No alert changes
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment