Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fail job if job output collection fails #5078
We now set a non-zero exit code to actually set a job to failed.
At first glance I don't love this I don't think. This wouldn't cause the datasets to fail if the exit code isn't used a condition to fail the job - which is the old default and a reasonable way to configure even newer tools. I feel like we should somehow more directly fail the job. We could either always fail the job when this exit code is encountered else where (maybe in job finish?) or better yet somehow set the exit code to