New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix exception in admin panel #5079

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Member

mvdbeek commented Nov 27, 2017

TypeError: Non-hexadecimal digit found
  File "galaxy/web/framework/middleware/sentry.py", line 40, in __call__
    iterable = self.application(environ, start_response)
  File "/bioinfo/guests/mvandenb/galaxy/.venv/local/lib/python2.7/site-packages/paste/recursive.py", line 85, in __call__
    return self.application(environ, start_response)
  File "/bioinfo/guests/mvandenb/galaxy/.venv/local/lib/python2.7/site-packages/paste/httpexceptions.py", line 640, in __call__
    return self.application(environ, start_response)
  File "galaxy/web/framework/base.py", line 136, in __call__
    return self.handle_request(environ, start_response)
  File "galaxy/web/framework/base.py", line 215, in handle_request
    body = method(trans, **kwargs)
  File "galaxy/web/framework/decorators.py", line 98, in decorator
    return func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/controllers/admin_toolshed.py", line 660, in manage_repositories
    return self.repository_installation_grid(trans, **kwd)
  File "galaxy/web/framework/helpers/grids.py", line 85, in __call__
    query = self.build_initial_query(trans, **kwargs)
  File "tool_shed/galaxy_install/grids/admin_toolshed_grids.py", line 334, in build_initial_query
    clause_list.append(self.model_class.table.c.id == trans.security.decode_id(tool_shed_repository_id))
  File "galaxy/web/security/__init__.py", line 107, in decode_id
    return int(id_cipher.decrypt(obj_id.decode('hex')).lstrip("!"))
  File "encodings/hex_codec.py", line 42, in hex_decode
    output = binascii.a2b_hex(input)

This is due to tool_shed_repository_ids being a json dump of a list
in certain conditions (noticed this after installing a new repository).

Fix exception in admin panel
TypeError: Non-hexadecimal digit found
  File "galaxy/web/framework/middleware/sentry.py", line 40, in __call__
    iterable = self.application(environ, start_response)
  File "/bioinfo/guests/mvandenb/galaxy/.venv/local/lib/python2.7/site-packages/paste/recursive.py", line 85, in __call__
    return self.application(environ, start_response)
  File "/bioinfo/guests/mvandenb/galaxy/.venv/local/lib/python2.7/site-packages/paste/httpexceptions.py", line 640, in __call__
    return self.application(environ, start_response)
  File "galaxy/web/framework/base.py", line 136, in __call__
    return self.handle_request(environ, start_response)
  File "galaxy/web/framework/base.py", line 215, in handle_request
    body = method(trans, **kwargs)
  File "galaxy/web/framework/decorators.py", line 98, in decorator
    return func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/controllers/admin_toolshed.py", line 660, in manage_repositories
    return self.repository_installation_grid(trans, **kwd)
  File "galaxy/web/framework/helpers/grids.py", line 85, in __call__
    query = self.build_initial_query(trans, **kwargs)
  File "tool_shed/galaxy_install/grids/admin_toolshed_grids.py", line 334, in build_initial_query
    clause_list.append(self.model_class.table.c.id == trans.security.decode_id(tool_shed_repository_id))
  File "galaxy/web/security/__init__.py", line 107, in decode_id
    return int(id_cipher.decrypt(obj_id.decode('hex')).lstrip("!"))
  File "encodings/hex_codec.py", line 42, in hex_decode
    output = binascii.a2b_hex(input)

This is due to `tool_shed_repository_ids` being a json dump of a list
in certain consitions (noticed this after installing a new repository).

@martenson martenson merged commit a82d325 into galaxyproject:release_17.09 Nov 28, 2017

7 checks passed

api test Build finished. 293 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 18.01 milestone Nov 28, 2017

@martenson

This comment has been minimized.

Member

martenson commented Nov 28, 2017

thanks @mvdbeek !

@mvdbeek mvdbeek deleted the mvdbeek:admin_panel_exception_fix branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment