New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Always fill `message` to avoid KeyError for sentry ERROR_TEMPLATE #5086

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
5 participants
@mvdbeek
Member

mvdbeek commented Nov 28, 2017

Otherwise I'm seeing

KeyError: u'message'
  File "galaxy/tools/error_reports/__init__.py", line 58, in submit_report
    response = plugin.submit_report(dataset, job, tool, **kwargs)
  File "galaxy/tools/error_reports/plugins/sentry.py", line 65, in submit_report
    error_message = ERROR_TEMPLATE.format(**extra)

@mvdbeek mvdbeek requested a review from erasche Nov 28, 2017

@galaxybot galaxybot added the triage label Nov 28, 2017

@erasche erasche changed the title from Always fill `message` to avoid KeyError for sentry ERROR_TEMPLATE to [17.09] Always fill `message` to avoid KeyError for sentry ERROR_TEMPLATE Nov 28, 2017

@erasche

This comment has been minimized.

Member

erasche commented Nov 28, 2017

yeah I have this on a branch and meant to upstream + backport. So sorry! 👍

@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Nov 28, 2017

No worries, just a minor glitch.

@jmchilton jmchilton merged commit ff3a6b0 into galaxyproject:release_17.09 Nov 28, 2017

6 of 7 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 18.01 milestone Mar 2, 2018

@martenson martenson added the kind/bug label Mar 7, 2018

@mvdbeek mvdbeek deleted the mvdbeek:sentry_report_fix branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment