New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n improvements French localization the sequel #5089

Merged
merged 9 commits into from Dec 7, 2017

Conversation

Projects
None yet
5 participants
@ValentinChCloud
Contributor

ValentinChCloud commented Nov 29, 2017

After the global update of the galaxy client, we want to continue the work on the i18n of galaxy.
New entries has been added to the basic Locale.js, based on the parsing of keywords like : title,description,help,tooltip,label.
More over this entries has been added in the french locale.js. There still need to translate these new sentences.
As said in #3762 , S'il vous plaît aider si vous parlez français :)

Thanks to @dannon

@galaxybot galaxybot added the triage label Nov 29, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 29, 2017

@martenson

Thank you very much for the contribution, please see comments inline.

@@ -374,7 +374,7 @@ var Tab = Backbone.View.extend({
_buildMenuItem: function(options) {
var self = this;
options = _.defaults(options || {}, {
title: "",
title: _l(""),

This comment has been minimized.

@martenson

martenson Dec 1, 2017

Member

this seems superfluous?

@@ -41,7 +41,7 @@ var History = Backbone.Model.extend(BASE_MVC.LoggableMixin).extend(
/** Adding title and singular tag */
searchAliases: {
title: "name",
title: _l("name"),

This comment has been minimized.

@martenson

martenson Dec 1, 2017

Member

this is not a translatable string I believe

//=============================================================================
/**
* backbone model for icon buttons
*/
var IconButton = Backbone.Model.extend({
defaults: {
title: "",
title: _l(""),

This comment has been minimized.

@martenson

martenson Dec 1, 2017

Member

same as above

@@ -337,7 +338,7 @@ var ButtonMenu = ButtonDefault.extend({
addMenu: function(options) {
this.collection.add(
Utils.merge(options, {
title: "",
title: _l(""),

This comment has been minimized.

@martenson

martenson Dec 1, 2017

Member

and all these

@@ -9,7 +10,7 @@ define(["qunit/test-app", "mvc/ui/ui-modal", "sinon"], function(testApp, GalaxyM
this.clock = sinon.useFakeTimers();
var self = this;
this.app = new GalaxyModal.View({
title: "Test title",
title: _l("Test title"),

This comment has been minimized.

@martenson

martenson Dec 1, 2017

Member

I do not think we want to i18n qunit test, which is this file and many below

@@ -15,25 +16,25 @@ var ConfigSetting = Backbone.Model.extend({
[
{
key: "name",
label: "Name",
label: _l("Name"),

This comment has been minimized.

@martenson

martenson Dec 1, 2017

Member

Are these labels ever rendered? If not, no need for i18n.

@@ -737,48 +738,48 @@ var SweepsterVisualizationView = Backbone.View.extend({
[
{
key: "name",
label: "Name",
label: _l("Name"),

This comment has been minimized.

@martenson

martenson Dec 1, 2017

Member

same as with labels above

This comment has been minimized.

@ValentinChCloud

ValentinChCloud Dec 1, 2017

Contributor

Ok I will remove all this "_l()" , remove all in qunit files and labels because after what you say plenty of them should not be translated.

@ValentinChCloud

This comment has been minimized.

Contributor

ValentinChCloud commented Dec 1, 2017

I updated files but it looks like my galaxy:dev branch is already too old, could it be easier to you, if I create a new branch i18n and rebase my dev branch to keep all my branches updated?

@martenson

This comment has been minimized.

Member

martenson commented Dec 2, 2017

@ValentinChCloud it seems the only conflicts are in the qunit/tests files - so if you drop all your changes in these files this PR should be fine

ValentinChCloud added some commits Dec 2, 2017

@ValentinChCloud

This comment has been minimized.

Contributor

ValentinChCloud commented Dec 2, 2017

it should be okay now

@dannon

This comment has been minimized.

Member

dannon commented Dec 7, 2017

Building client and merging this, thanks for all the work @ValentinChCloud!

It'd be great to set up some infrastructure for people to more easily see bits that need translation/syncing, moving forward.

@dannon dannon merged commit d042f44 into galaxyproject:dev Dec 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: JavaScript 20 new alerts
Details
@dannon

This comment has been minimized.

Member

dannon commented Dec 7, 2017

(one issue with the client build from this; following up separately with a PR to build and fix it)

@yvanlebras

This comment has been minimized.

Contributor

yvanlebras commented Dec 7, 2017

Thanks @dannon for your help! What do you mean about infrastructure ? a dedicated web site, something like this and/or more communication ?

@dannon

This comment has been minimized.

Member

dannon commented Dec 7, 2017

@yvanlebras I'm not exactly sure what the best approach would be, but some sort of interface where you can see the source string, translations in multiple languages, what needs to be filled in still, etc., in an easier method than browsing the nls/locale bundles.

@yvanlebras

This comment has been minimized.

Contributor

yvanlebras commented Dec 7, 2017

OK, I'm in. Totally agree with you and this is the way I want to explore for Galaxy translation related tasks (also for tools and other things...) with @manabuishii and @Abdelazeem-Elhabyan and related to this issue. I will try to set up something.... Thanks !

@martenson

This comment has been minimized.

Member

martenson commented Dec 7, 2017

Maybe something like https://poeditor.com/ or similar? Bunch of those collaborative platforms have free tier for open source.

@yvanlebras

This comment has been minimized.

Contributor

yvanlebras commented Dec 8, 2017

Thanks @martenson ! I found this too:
What about using converters like this http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/txt2po.html and related infrastructure http://pootle.translatehouse.org/discover.html ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment