Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packed symlink back pending a deprecation cycle. #5094

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

dannon commented Nov 30, 2017

We removed the (ancient, redundant) static/scripts/packed symlink in recent client work, but on further review it should probably stick around a full release+deprecation cycle. Everything internally points directly to static, but our admin materials, playbooks, etc., still reference the 'packed' static path in many places. We should formally deprecate this w/ 18.01, and then remove it (again).

Ping @bgruening.

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Nov 30, 2017

Thanks @dannon!

@bgruening bgruening merged commit 893e494 into galaxyproject:dev Nov 30, 2017

7 checks passed

api test Build finished. 317 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 163 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 58 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to galaxyproject/ansible-galaxy-extras that referenced this pull request May 24, 2018

Update for galaxyproject/galaxy#5094.
I think packed has been deprecated as long as this project has existed.

dannon added a commit to galaxyproject/ansible-galaxy-extras that referenced this pull request May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.