New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sample tracking backend support, preserve data tables #5103

Merged
merged 36 commits into from Dec 1, 2017

Conversation

Projects
None yet
4 participants
@guerler
Contributor

guerler commented Nov 30, 2017

This PR removes the sample tracking features entirely from the backend. The database migration scripts remain unchanged.

# Sample request associated class
class Request(object, Dictifiable):

This comment has been minimized.

@dannon

dannon Nov 30, 2017

Member

Out of curiosity, can we actually remove these, or does it break things if they don't exist?

This comment has been minimized.

@guerler

guerler Nov 30, 2017

Contributor

These classes are used in the model mapping. Removing them without further modifications raises a missing class exception at start up.

This comment has been minimized.

@dannon

dannon Nov 30, 2017

Member

Got an example? Can't we remove them from the mapping, too?

This comment has been minimized.

@guerler

guerler Nov 30, 2017

Contributor

@dannon and I talked about this. The HistoryDatasetAssociationAnnotationAssociation are defined in a similar fashion. In the section below, I removed the mapping and model without modifying the migration scripts. The alternative would be to leave the mapping as it is.

@guerler guerler added status/review and removed status/WIP labels Nov 30, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Dec 1, 2017

I'm aggressively +1 on this.

@martenson martenson merged commit dad11b8 into galaxyproject:dev Dec 1, 2017

7 checks passed

api test Build finished. 331 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 164 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 59 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 117 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Member

martenson commented Dec 1, 2017

Thanks @guerler, good cleanup!

@guerler

This comment has been minimized.

Contributor

guerler commented Dec 1, 2017

Thanks for the review guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment