New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resilience of filter detection, add error messages, fix identifiers #5106

Merged
merged 10 commits into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@guerler
Contributor

guerler commented Dec 1, 2017

When enabling toolbox filter examples from galaxy.ini without providing the associated python functions the Toolbox filter view is not accessible. A single error message indicating a backend error is displayed instead. With this revision the view is loaded and missing filter modules are highlighted individually. This PR also fixes faulty identifiers for section and label specifications.

untitled

@guerler guerler added this to the 18.01 milestone Dec 1, 2017

@guerler guerler added the kind/bug label Dec 1, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Dec 1, 2017

This doesn't sound right - I just cloned a clean Galaxy and it started up without an exception. We have a Travis test that verifies it starts cleanly as well.

Do you have a missing filter set in your galaxy.ini? I would hope and probably expect Galaxy to fail to start if a filter is configured and cannot be found. I'm happy to see the message it fails to start with improve though.

@guerler

This comment has been minimized.

Contributor

guerler commented Dec 1, 2017

@jmchilton, you are correct. It's related to declaring filter modules in galaxy.ini without providing the module files. I'll edit the description above. Thanks.

@dannon

This comment has been minimized.

Member

dannon commented Dec 1, 2017

I'm with John here, I think that should be a fatal configuration error that requires a fix before Galaxy will start.

@guerler

This comment has been minimized.

Contributor

guerler commented Dec 1, 2017

I was not clear. Galaxy starts up but the filter view in the user preferences does not appear. I'll see if I can improve the ui error message.

@guerler guerler changed the title from Improve resilience of filter detection to Improve resilience of filter detection, add error messages, fix identifiers Dec 1, 2017

@guerler guerler added status/review and removed status/WIP labels Dec 1, 2017

@dannon dannon merged commit 15928b5 into galaxyproject:dev Dec 4, 2017

1 of 7 checks passed

lgtm analysis: JavaScript Commits either could not be fetched or could not be merged
Details
api test Test started.
Details
framework test Test started.
Details
integration test Test started.
Details
selenium test Test started.
Details
toolshed test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@guerler

This comment has been minimized.

Contributor

guerler commented Dec 4, 2017

Thanks @dannon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment