New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onload webhook toggles. #5116

Merged
merged 11 commits into from Dec 7, 2017

Conversation

Projects
None yet
4 participants
@dannon
Member

dannon commented Dec 1, 2017

Fixes #5112 and #4969. Ended up refactoring a bit of onload.js, which necessitated a tour.js refactor as well.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Dec 2, 2017

Selenium test failures related to tool describing tours look legit, let me know if you want me to dig into this:

https://jenkins.galaxyproject.org/job/docker-selenium/421/artifact/421-test-errors/test_generate_tour_with_data2017120121461512164763/browser.log.json

@dannon

This comment has been minimized.

Member

dannon commented Dec 2, 2017

Yeah, was a last minute startTourWithData -> giveTourWithData that only had client added to the commit, I got it.

@dannon

This comment has been minimized.

Member

dannon commented Dec 7, 2017

Since they're not just /static, resolving conflicts with a rebase.

@martenson martenson merged commit fe0fdeb into galaxyproject:dev Dec 7, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 59 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Member

martenson commented Dec 7, 2017

Thanks @dannon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment