New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow tool copy tweaks #5124

Merged
merged 8 commits into from Dec 5, 2017

Conversation

Projects
None yet
5 participants
@dannon
Member

dannon commented Dec 4, 2017

xref #5087

This refines the copy/paste behavior binding of ctrl+c/v to still allow regular use (for example, in tool form or annotation boxes).

It also forces an input blur when nodes are changed. Kinda surprised this hasn't been an issue before now.

Includes minor cleanup/refactoring.

// pass that through and skip the workflow copy/paste logic.
if (
document.activeElement &&
document.activeElement.type !== "textarea" &&

This comment has been minimized.

@martenson

martenson Dec 4, 2017

Member

I like this very much.

@galaxybot galaxybot added this to the 18.01 milestone Dec 4, 2017

@anatskiy

This comment has been minimized.

Contributor

anatskiy commented Dec 4, 2017

@dannon thanks for the improvements!

@anatskiy

This comment has been minimized.

Contributor

anatskiy commented Dec 5, 2017

@dannon I notices that if there is just one node on the canvas, it's impossible to copy it, focus on an input element and then paste it because the input is still focused (I assume it's intended behavior). Would it be a good idea to unfocus an input on canvas click too?

@dannon

This comment has been minimized.

Member

dannon commented Dec 5, 2017

@anatskiy Hrmm. Yeah, intended behavior, my main concern is just not breaking the expected copy/paste functionality in the normal text boxes. I hadn't considered a single node not being able to blur. I'll blur on the canvas click, too. (done in 0096a58)

@bgruening

This comment has been minimized.

Member

bgruening commented Dec 5, 2017

Nice! Tested and works! Thanks for improving!

@bgruening bgruening merged commit f09944a into galaxyproject:dev Dec 5, 2017

7 checks passed

api test Build finished. 332 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 59 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 117 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment