New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test resubmit for dynamic JobDestination structures. #5139

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Member

jmchilton commented Dec 6, 2017

Inspired by a question from @erasche.

also how does resubmit work in the dynamic destination world? I can understand that working in non-dynamic world because you could loop over the existing destinations. But when the destination is generated completely dynamically in response to tool_id + other info?

It seems to just work - though I'm a bit shocked it works with somehow persisting the job destination resubmission criteria (perhaps this is re-generated after failure or perhaps it works only in this test case because it is cached).

If this test is missing something and we do need to work a bit harder to persist the resubmission criteria - I think something like 56d93c0 would work - though we should rework that commit a bit a give it a real DB field instead of persisting it with the job destination parameters.

@jmchilton jmchilton added this to the 18.01 milestone Dec 6, 2017

@erasche erasche merged commit 044dcfb into galaxyproject:dev Dec 8, 2017

6 checks passed

api test Build finished. 332 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment