New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Fix connecting non-input modules to subworkflow inputs. #5140

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Member

jmchilton commented Dec 6, 2017

Fix thanks to @erasche.

It has been broken since introduced in 16.01 - sorry all. I went to retest this again and it worked for me and then I realized what the problem is - it just happens that the test tools I normally use (cat, head, random lines, etc...) all have the same complete hack of an output type - the one random datatype that will happen to work with non-input modules.

Fixes #1739

Fix connecting non-input modules to subworkflow inputs.
It has been broken since introduced in 16.01, it just happens that the test tools I normally use have the same complete hack of an output type.
@erasche

This comment has been minimized.

Member

erasche commented Dec 7, 2017

Tested locally, LGTM. 👍

@nsoranzo nsoranzo merged commit 86ab6fd into galaxyproject:release_17.05 Dec 7, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Dec 7, 2017

Merged forward.

@bgruening

This comment has been minimized.

Member

bgruening commented Dec 7, 2017

Does this needs to be merged forward?

@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Dec 7, 2017

I did that already, see comment above.

@bgruening

This comment has been minimized.

Member

bgruening commented Dec 7, 2017

My github is not updating the comments anymore. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment