New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for handling delayed steps within subworkflows. #5145

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Member

jmchilton commented Dec 6, 2017

With new test case to verify this fix is needed. The previous test case that was verifying collection mapping and rescheduling of subworkflows turned out to really be testing the connections with respect to the outer workflow since only the last step of the subworkflow required rescheduling iterations. This newer test case also verifies the connections within the subworkflow also because the subworkflow needs to stop and wait for a job in the middle of subworkflow not just at the end.

Huge thanks to @mmiladi for reporting this @ #5013 (comment).

Fixes for handling delayed steps within subworkflows.
With new test case to verify this fix is needed. The previous test case that was verifying collection mapping and rescheduling of subworkflows turned out to really be testing the connections with respect to the outer workflow since only the last step of the subworkflow required rescheduling iterations. This newer test case verifies the connections within the subworkflow also - in addition to re-testing the connections and mapping in the outer workflow.
@mmiladi

This comment has been minimized.

Contributor

mmiladi commented Dec 7, 2017

@jmchilton wonderful. Many thanks!

@bgruening

This comment has been minimized.

Member

bgruening commented Dec 7, 2017

This fixes @mmiladi problem. Thanks.

@bgruening bgruening merged commit c8937c8 into galaxyproject:dev Dec 7, 2017

6 checks passed

api test Build finished. 333 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 59 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment