New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset hashtag display improvements #5155

Merged
merged 10 commits into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Dec 7, 2017

fixes #5100

For history-based tags, still displays all of them in a scrollable pane while constraining the space consumed. Adds a tooltip showing total number of tags at a glance.
For tags in select boxes, only displays the first 5 matches, with an additional tag saying "N more tags", since scrolling around in the select2 isn't an option.

image

@dannon dannon changed the title from [WIP] Dataset hashtag display improvements to Dataset hashtag display improvements Dec 7, 2017

@dannon dannon added status/WIP and removed status/review labels Dec 7, 2017

@dannon dannon added status/review and removed status/WIP labels Dec 7, 2017

@galaxybot galaxybot added this to the 18.01 milestone Dec 7, 2017

@dannon

This comment has been minimized.

Member

dannon commented Dec 19, 2017

Pulled upstream changes and rebuilt.

@bgruening

This comment has been minimized.

Member

bgruening commented Dec 19, 2017

also works for me and @guerler already gave his +1, so ready for merge.

@bgruening bgruening merged commit 62a3a5c into galaxyproject:dev Dec 19, 2017

6 checks passed

api test Build finished. 336 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Member

dannon commented Dec 19, 2017

@bgruening Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment