New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French localization part 2 #5157

Merged
merged 9 commits into from Dec 22, 2017

Conversation

Projects
None yet
6 participants
@ValentinChCloud
Contributor

ValentinChCloud commented Dec 7, 2017

PR #5089 have been accepted, we are calling people to translate approximately 190 new sentences for the french dictionnary.
As said in #3762 , S'il vous plaît aider si vous parlez français :)

Stop doing a hard job and come and enjoy, time of a Pull Request 🎈

@yvanlebras @abretaud @lecorguille @bebatut @mvdbeek , you're always welcome and bring coworkers!
@Alanamosse come here!

ValentinChCloud and others added some commits Dec 7, 2017

@yvanlebras

This comment has been minimized.

Contributor

yvanlebras commented Dec 7, 2017

Let's go for the show!!!

@galaxybot galaxybot added the triage label Dec 7, 2017

@galaxybot galaxybot added this to the 18.01 milestone Dec 7, 2017

@dannon

This comment has been minimized.

Member

dannon commented Dec 7, 2017

@yvanlebras The plan is to leave this as WIP for a while and accumulate contributions here, right?

@yvanlebras

This comment has been minimized.

Contributor

yvanlebras commented Dec 7, 2017

That's exactely what we propose @dannon if you agree that this is a good way to proceed. Tanks for your help!

@dannon

This comment has been minimized.

Member

dannon commented Dec 7, 2017

@yvanlebras Sounds good to me! I just wanted to make sure I labelled the issue correctly :)

yvanlebras and others added some commits Dec 8, 2017

Merge pull request #2 from yvanlebras/patch-4
A first pass on the "admin" UI related section
Merge pull request #3 from yvanlebras/patch-5
Second pass after coffee break
Report: false,
"Error Report": false,
"Error Report": "Rapoprt d'erreur",

This comment has been minimized.

@FredericBGA

FredericBGA Dec 13, 2017

Contributor

une typo :
Rapport d'erreur

@FredericBGA

Hello

I put some comments.
Nice work.

@@ -246,24 +246,24 @@ define({
Trackster: false,
Visualize: false,
// ---------------------------------------------------------------------------- dataset-error
"Any additional comments you can provide regarding what you were doing at the time of the bug.": false,
"Your email address": false,
"Any additional comments you can provide regarding what you were doing at the time of the bug.": "N'importe quels commentaires que vous pouvez fournir concernant ce que vous faisiez lorsque le bug est apparu",

This comment has been minimized.

@FredericBGA

FredericBGA Dec 13, 2017

Contributor

Je mettrais au singulier:
N'importe quel commentaire

// ---------------------------------------------------------------------------- library-librarytoolbar-view
"Create New Library": false,
"Create New Library": "Créer une nouvelle librairie",

This comment has been minimized.

@FredericBGA

FredericBGA Dec 13, 2017

Contributor

bibliothèque ?

@ValentinChCloud

This comment has been minimized.

Contributor

ValentinChCloud commented Dec 13, 2017

@FredericBGA thanks to your comments, the modifications have been done

@dannon dannon merged commit 75060db into galaxyproject:dev Dec 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dannon

This comment has been minimized.

Member

dannon commented Dec 22, 2017

Thanks everyone! We can open a new one with more changes, as there are any -- this one seems to be done for now. I also have some ideas about localization file management that I need to write up, which will hopefully make it even easier for us to do this work and generate bundles moving forward.

@martenson martenson removed the status/WIP label Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment