New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy request controller from reports app #5182

Merged
merged 5 commits into from Dec 11, 2017

Conversation

Projects
None yet
4 participants
@guerler
Contributor

guerler commented Dec 10, 2017

This PR removes remaining makos and sequence tracking features from the reports app.

@guerler guerler added this to the 18.01 milestone Dec 10, 2017

@guerler guerler requested a review from martenson Dec 10, 2017

@martenson

This comment has been minimized.

Member

martenson commented Dec 11, 2017

@guerler I thought about this when we were removing the requests from Galaxy (sorry for not bringing it up then). I am not sure we want to fo this, since the requests database stays intact, this could still be useful for looking into data there. What about hiding this behind config that is False by default?

@guerler

This comment has been minimized.

Contributor

guerler commented Dec 11, 2017

I think at this point we should remove it since the data is not in the model mapping anymore it just exists in the database but we are not keeping track of it. In other words model.Request does not exists anymore within Galaxy: https://github.com/galaxyproject/galaxy/pull/5182/files#diff-31531c415fb7f30199dcc455872a51eaL68.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Dec 11, 2017

@martenson It should be possible to run an older version of the reports app with a newer version of Galaxy if you simply host them from different Git roots. If anyone finds this information useful - they can do that - but these people don't exist I don't think.

@dannon dannon merged commit 1e8c15b into galaxyproject:dev Dec 11, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment