New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin data tables vue #5191

Merged
merged 7 commits into from Dec 15, 2017

Conversation

Projects
None yet
5 participants
@dannon
Member

dannon commented Dec 11, 2017

Cherrypick of relevant commit applied to dev cleanly; #5191, minor cleanup.

new Vue(UserAPIKeys).$mount(vuemount);
var vueMount = document.createElement("div");
this.page.display(vueMount);
new Vue(UserAPIKeys).$mount(vueMount);

This comment has been minimized.

@guerler

guerler Dec 11, 2017

Contributor

Can we augment the display caller such that it does the mounting for Vue-components internally? The call might look like this: this.page.display(new Vue(UserAPIKeys)).

This comment has been minimized.

@dannon

dannon Dec 11, 2017

Member

@guerler Yeah, that's on my list (I mentioned this in a previous Vue PR). If you want to see that prior to merge of this PR, I guess I can go ahead and add something simple for full-page vue components.

This comment has been minimized.

@guerler

guerler Dec 11, 2017

Contributor

Cool. Its up to you.

@galaxybot galaxybot added this to the 18.01 milestone Dec 11, 2017

@guerler guerler merged commit 0d8520f into galaxyproject:dev Dec 15, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Member

bgruening commented Dec 17, 2017

Cool! @dannon @guerler is this the right way to go for grids? Or do you plan to use an official vue-grid component? Is anyone working on this?

@guerler

This comment has been minimized.

Contributor

guerler commented Dec 18, 2017

Admin tables are very minimal i.e. there are no operations, options and redirects to forms. Whichever solution we find for regular grids should also be applicable to these type of table views.

@dannon

This comment has been minimized.

Member

dannon commented Dec 18, 2017

@bgruening Yeah, this was a step forward for these grids in particular, but the big shift will happen when we swap the mvc/grid-* itself to a vue-grid component. Then we can update these as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment