Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample tracking removal cleanup #5204

Merged
merged 2 commits into from Dec 13, 2017

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

dannon commented Dec 12, 2017

display_common currently blows up when used in various modes because the models don't exist (when displaying an embedded trackster viz, for example)

security/__init__ doesn't blow up, but these are unused methods as far as I can tell.

ping @guerler; display_common was broken with #5103

@guerler

This comment has been minimized.

Copy link
Contributor

guerler commented Dec 12, 2017

@dannon thanks

@galaxybot galaxybot added this to the 18.01 milestone Dec 12, 2017

@guerler guerler merged commit 84c069e into galaxyproject:dev Dec 13, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member Author

dannon commented Dec 13, 2017

Sure, thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.