Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Re-organize edge case upload options for my own understanding. #5206
I think setting each of these variables once and simplifying the context they are used in (in the case of purge_upload) makes it more clear what each variable is and how it is set. I also think one, more detailed comment for each variable helps.
Ping @mvdbeek - you are the one who understands these run-as-real-user options the best based on #4539. Does this new organization make sense to you - does it look functionally equivalent to the previous way things were working?
Dec 14, 2017
6 checks passed
This is all wrong...
run_as_real_user=trans.app.config.external_chown_script is None
... doesn't make any sense right? I thought I was finally not confused but I still am it seems.
Update: The previous version of this did the same thing:
run_as_real_user = in_place = dataset.get('in_place', True)
I'm not sure this broke anything that wasn't already broken - but it seems broken to me.
Okay - I think the
Okay... this makes some sense to me. So this comment I added:
was 100% wrong - I should invert the check and the run_as_real_user value and the comment should be:
I'm opening a PR with this to re-clarify.