New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force window jquery access for charts #5210

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
4 participants
@dannon
Member

dannon commented Dec 13, 2017

This isn't great, but charts and the rest of the viz framework are being refactored into bundles with correct imports, etc., that will avoid this hackery.

@gregvonkuster Let me know if this doesn't fix it for ya.

Force window jquery access for charts.mako. This isn't great, but cha…
…rts *and* the rest of the viz framework are being refactored into bundles that will avoid this hackery.
@gregvonkuster

This comment has been minimized.

Contributor

gregvonkuster commented Dec 14, 2017

Thanks @dannon

@bgruening bgruening merged commit 6fc9296 into galaxyproject:dev Dec 17, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Member

bgruening commented Dec 17, 2017

Thanks @dannon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment