New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3: finish first pass on whole codebase #5215

Merged
merged 2 commits into from Dec 14, 2017

Conversation

Projects
None yet
3 participants
@nsoranzo
Member

nsoranzo commented Dec 14, 2017

xref. #1715

@dannon

This comment has been minimized.

Member

dannon commented Dec 14, 2017

LGTM, nice! Going to do the dependencies upstream, next? ;)

@dannon dannon merged commit 3b7f401 into galaxyproject:dev Dec 14, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Dec 15, 2017

A couple of the Python2-only dependencies are unmaintained, but I'd like to try to move to use Cheetah3.

I'm also scanning the codebase for missed files or regressions, and stuff that 2to3 doesn't help fixing, like list.sort() and sorted() that I mentioned on gitter.

Hopefully, with the help of @jmchilton, we will soon be able to run unit tests, which will surely fail, but should still help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment