New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shell plugins with different parameters to co-exist #5223

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
4 participants
@mvdbeek
Member

mvdbeek commented Dec 15, 2017

I broke this in #4358 by re-using shell plugin instances. I'm not sure this warrants a backport, but let me know if you disagree.

Also addresses @jmchilton's comment in the original PR.

@galaxybot galaxybot added this to the 18.01 milestone Dec 15, 2017

@jmchilton jmchilton merged commit ad0459d into galaxyproject:dev Dec 15, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Dec 15, 2017

Awesome - thanks for the fix!

@mvdbeek mvdbeek deleted the mvdbeek:fix_second_submit_host branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment