New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow list show-in-tool-panel callback bugfix. #5234

Merged
merged 6 commits into from Dec 22, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Dec 19, 2017

This changes the workflow list showInToolPanel to wait for a response prior to changing the page location. This fixes the behavior where in some situations, without this, the navigation happens before the save() request is made, and nothing changes, making it impossible to use the feature.

dannon added some commits Dec 19, 2017

Fix workflow list showInToolPanel toggling to use a success callback …
…for reload. Currently this is unsable in firefox, because the reload happens immediately before the request gets sent async.

@dannon dannon changed the title from Workflow list fixes to Workflow list show-in-tool-panel callback bugfix. Dec 19, 2017

@galaxybot galaxybot added this to the 18.01 milestone Dec 19, 2017

@bgruening

This comment has been minimized.

Member

bgruening commented Dec 21, 2017

Works for me. @dannon can you resolve the conflict?

@dannon

This comment has been minimized.

Member

dannon commented Dec 21, 2017

@bgruening Sure, give me 2 minutes.

@dannon

This comment has been minimized.

Member

dannon commented Dec 21, 2017

@bgruening Done! Thanks for testing it.

@bgruening bgruening merged commit 87b2540 into galaxyproject:dev Dec 22, 2017

6 checks passed

api test Build finished. 336 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 65 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment