New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix wrong tool id after switching versions #5249

Merged
merged 2 commits into from Jan 1, 2018

Conversation

Projects
None yet
3 participants
@mvdbeek
Member

mvdbeek commented Dec 31, 2017

This was reported by @bgruening:
We need to also set the content_id, otherwise the old id will still be present. You can see this by switching a tool version, downloading the workflow and then inspecting the tool ids in the workflow.

@mvdbeek mvdbeek added this to the 18.01 milestone Dec 31, 2017

@bgruening

This comment has been minimized.

Member

bgruening commented Jan 1, 2018

Great! Thanks @mvdbeek - works for me!

@martenson martenson merged commit 41ce472 into galaxyproject:release_17.09 Jan 1, 2018

6 checks passed

api test Build finished. 295 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Jan 26, 2018

Fix subworkflow creation
This fixes galaxyproject#5396. The problem was that we would override the content_id with an
undefined value. Broken in galaxyproject#5249.

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Jan 26, 2018

Fix subworkflow creation
This fixes galaxyproject#5396. The problem was that we would override the content_id with an
undefined value. Broken in galaxyproject#5249.

@mvdbeek mvdbeek deleted the mvdbeek:fix_wrong_tool_id_after_switching_versions branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment