Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Catch and display error when displaying broken BAM file #5253

Conversation

Projects
None yet
5 participants
@mvdbeek
Copy link
Member

mvdbeek commented Jan 2, 2018

This should fix #5252.

@mvdbeek mvdbeek changed the base branch from dev to release_17.09 Jan 2, 2018

@mvdbeek mvdbeek changed the title [17.09] Catch error when displaying broken BAM file [17.09] Catch and display error when displaying broken BAM file Jan 2, 2018

@dannon

This comment has been minimized.

Copy link
Member

dannon commented Jan 5, 2018

Travis failures are due to job configuration, and not the changes in this PR.

@dannon dannon merged commit bdbc1a6 into galaxyproject:release_17.09 Jan 5, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
api test Build finished. 295 tests run, 5 skipped, 0 failed.
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

galaxybot commented Jan 5, 2018

This PR was merged without a milestone attached.

@nsoranzo nsoranzo added this to the 18.01 milestone Jan 5, 2018

@mvdbeek mvdbeek deleted the mvdbeek:catch_pysam_errors_when_viewing_bam_files branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.